use jest-puppeteer-docker for docker #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this since I tried to make it work on an actual project but it turned out to be more complicated than necessary to get jest-puppeteer-docker to build an image in CI where there is no docker cli available. Instead I opted to use a similar logic to what is here right now, but instead of using the custom Dockerfile I used zenika/alpine-chrome image. Either way, I've currently got this forked up internally so if any of the maintainers want to discuss the changes I needed to do to get this working properly (the most important of which was resolving #75) and would like to see these changes PR-d back here, ping me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75, I think.
The example snapshots have been updated since the docker image built/used by jest-puppeteer-docker uses a different default font (not sure why or if we can force that to not change somehow).